Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover new devices from ZDO NWK_addr_rsp and IEEE_addr_rsp #156

Closed
wants to merge 1 commit into from

Conversation

Shulyaka
Copy link
Contributor

@Shulyaka Shulyaka commented Oct 1, 2023

Handle new device join upon receiving of a ZDO IEEE Address Response or a Network Address Response.
This is already implemented in zigpy.

@puddly
Copy link
Contributor

puddly commented Oct 1, 2023

Why not pass the ZDO requests through to zigpy so that the radio library doesn't have to duplicate this logic?

@Shulyaka
Copy link
Contributor Author

Shulyaka commented Oct 1, 2023

This is the way it was implemented before. I originally had an impression that there is not enough information to fill up the t.ZigbeePacket, but now that I think of it, it might be actually possible. I will conduct an experiment.

@Shulyaka Shulyaka marked this pull request as draft October 1, 2023 08:40
@Shulyaka
Copy link
Contributor Author

Shulyaka commented Oct 3, 2023

Superseded by #160

@Shulyaka Shulyaka closed this Oct 3, 2023
@Shulyaka Shulyaka deleted the ieee_discovery branch October 3, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants