Convert dataclasses to pydantic models #245
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## projects/zha-web-socket-server #245 +/- ##
===============================================================
Coverage 96.31% 96.32%
===============================================================
Files 61 62 +1
Lines 9366 9383 +17
===============================================================
+ Hits 9021 9038 +17
Misses 345 345 ☔ View full report in Codecov by Sentry. |
|
As long as unit tests pass, I think this may actually be something that can be merged straight into |
separate. This is actually auto validating the objects on creation and I want to make sure everything is good before putting it in dev. |
dmulcahey
force-pushed
the
dm/switch-to-pydantic
branch
from
91e6cbb
to
94346b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards adding web socket functionality. This PR converts the dataclass objects to Pydantic models so they can be validated, serialized and deserialized between the WS server and clients.
Note: the target branch is a project branch and NOT dev.