-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add V2 Quirk for telink devices with custom ZigbeeTlc
firmware
#3719
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3719 +/- ##
==========================================
+ Coverage 89.87% 90.11% +0.24%
==========================================
Files 320 321 +1
Lines 10381 10452 +71
==========================================
+ Hits 9330 9419 +89
+ Misses 1051 1033 -18 ☔ View full report in Codecov by Sentry. |
046a8ee
to
7516a67
Compare
a7bcfc2
to
ad6697a
Compare
ad6697a
to
1da86f9
Compare
ZigbeeTlc
firmware
ZHA seems to be ignoring the |
min_value=-327.67, | ||
max_value=327.67, | ||
step=0.01, | ||
# unit=PERCENTAGE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for all units was merged in ZHA with zigpy/zha#352, so we can add this now (and below), as the next HA/ZHA versions will support this.
Proposed change
Adds quirk for devices that are originally Bluetooth devices but can be modified to use ZigBee with a custom firmware
Edit: Some of these are already Zigbee devices but can be differentiated by the
-z
postfix from the ones with original fw, or in case of the tuya devices because they actually also have the correct model and manufacturer set ^^Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black