Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya 3 phase power meter _TZE204_ugekduaj #3571

Merged
merged 7 commits into from
Jan 26, 2025

Conversation

abmantis
Copy link
Contributor

@abmantis abmantis commented Dec 2, 2024

Proposed change

Additional information

Requires: home-assistant/core#133972 and zigpy/zha#339

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (f0a7498) to head (bf1b6b6).
Report is 13 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3571      +/-   ##
==========================================
+ Coverage   90.47%   90.50%   +0.02%     
==========================================
  Files         322      323       +1     
  Lines       10575    10605      +30     
==========================================
+ Hits         9568     9598      +30     
  Misses       1007     1007              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA. labels Dec 2, 2024
@abmantis abmantis marked this pull request as ready for review January 26, 2025 00:37
type=t.uint8_t,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.POWER_FACTOR,
# unit=PERCENTAGE, # ZHA fails to validate this one
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this now. All units are supported with zigpy/zha#352 now.

@TheJulianJES TheJulianJES changed the title Add TS0601 3 phase meter Add Tuya 3 phase power meter _TZE204_ugekduaj Jan 26, 2025
@TheJulianJES TheJulianJES added the needs review This PR should be reviewed soon, as it generally looks good. label Jan 26, 2025
@abmantis abmantis requested a review from TheJulianJES January 26, 2025 15:31
@TheJulianJES TheJulianJES added the smash This PR is close to be merged soon label Jan 26, 2025
@abmantis abmantis requested a review from TheJulianJES January 26, 2025 23:37
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@TheJulianJES TheJulianJES merged commit 2f1dd9b into zigpy:dev Jan 26, 2025
9 checks passed
@abmantis abmantis deleted the TS0601_3ph_meter branch January 27, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review This PR should be reviewed soon, as it generally looks good. smash This PR is close to be merged soon Tuya Request/PR regarding a Tuya device v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants