-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tuya 3 phase power meter _TZE204_ugekduaj
#3571
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3571 +/- ##
==========================================
+ Coverage 90.47% 90.50% +0.02%
==========================================
Files 322 323 +1
Lines 10575 10605 +30
==========================================
+ Hits 9568 9598 +30
Misses 1007 1007 ☔ View full report in Codecov by Sentry. |
zhaquirks/tuya/ts0601_din_power.py
Outdated
type=t.uint8_t, | ||
state_class=SensorStateClass.MEASUREMENT, | ||
device_class=SensorDeviceClass.POWER_FACTOR, | ||
# unit=PERCENTAGE, # ZHA fails to validate this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add this now. All units are supported with zigpy/zha#352 now.
_TZE204_ugekduaj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Proposed change
Additional information
Requires: home-assistant/core#133972 and zigpy/zha#339
Checklist
pre-commit
checks pass / the code has been formatted using Black