std.Build: allow packages to expose arbitrary LazyPaths by name #21386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlugg
added
release notes
mlugg
force-pushed
the
build-package-named-lazypath
branch
from
5f0c834
to
aaf41ed
Compare
|
Seems like this PR could help address this use case? |
|
From just the description this sounds like an alternate take on #21380 ? |
|
No, it's the exact opposite @rohlem. |
|
#21380 allows the dependee to pass lazy paths to the dependency; this allows the dependency to pass lazy paths to the dependee. |
InKryption
reviewed
Sep 11, 2024
mlugg
force-pushed
the
build-package-named-lazypath
branch
from
aaf41ed
to
bf3bbda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement to the build system. There's no corresponding issue -- @andrewrk, I'll therefore wait for your approval on this one.
It seems reasonable and useful for packages to be allowed to expose arbitrary
LazyPaths to dependants; for instance, an output file/dir from aStep.Run. I ran into this when helping @sphaerophoria make a package which exposes a bunch of Qt stuff by calling into CMake rather than porting the build system to Zig. You can also imagine situations in pure-Zig-land where this would be helpful; for instance, perhaps a package wants to expose a file containing some kind of generated JSON/ZON data (generated by a Zig program).(Also, use decl literals for a couple of inits :D)