Skip to content

fetch: combine unpack error validation in a single function #19618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

ianic
Copy link
Contributor

@ianic ianic commented Apr 11, 2024

Follow up of: #19500
discussion

@andrewrk
Copy link
Member

I like it this way. What do you think?

@ianic
Copy link
Contributor Author

ianic commented Apr 11, 2024

I was worried that this one will be harder to test but that was not the problem at the end.
Now all validate is covered. In that sense I like it more.

I also found a bug in previous implementation. Here I'm iterating over all errors but should use only non filtered something like self.errors[0..self.errors_count].

@andrewrk andrewrk enabled auto-merge (rebase) April 11, 2024 21:43
@andrewrk andrewrk merged commit 9cfac47 into ziglang:master Apr 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants