resinator: Fix INCLUDE var handling and sync with upstream
#17608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The INCLUDE variable being used during `.rc` preprocessing was an accidental regression in ziglang#17412. Closes ziglang#17585. resinator changes: source_mapping: Protect against NUL bytes in #line filenames lex: Avoid recalculating column on every tab stop within string literals Proper error handling for failing to open cwd instead of `catch unreachable` Use platform-specific delimiter for INCLUDE env var parsing
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/changes:ignore_include_env_varnot being set when preprocessing.rcfiles. Closes resinator should not observe any environment variables #17585/por/:no-preprocessoptions for an.rcfile an error when going throughzig build-exe/zig build/etcsrc/resinatorchanges:INCLUDEenv var related changes in 09dea95 sinceINCLUDEis now never read by anything exceptzig rc.rccompilation (an improvement on a change in 09dea95)INCLUDE