Skip to content

Package.Fetch: wrap operations involving tmp_directory in a block #17487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

Package.Fetch: wrap operations involving tmp_directory in a block #17487

merged 1 commit into from
Oct 12, 2023

Conversation

der-teufel-programming
Copy link
Contributor

This makes tmp_directory close before calling renameTmpIntoCache which fixes occurences of those AccessDenied errors that aren't synonymous with PathAlreadyExists on Windows

@der-teufel-programming
Package.Fetch: wrap operations involving tmp_directory in a block
d2192ae 
This makes tmp_directory close before calling renameTmpIntoCache which fixes occurences of those AccessDenied errors that aren't synonymous with PathAlreadyExists on Windows
@der-teufel-programming
Copy link
Contributor Author

This should fix remaining issues mentioned in #17477

@andrewrk andrewrk enabled auto-merge (rebase) October 11, 2023 22:59
@andrewrk
Copy link
Member

Nice work, thank you!

@andrewrk andrewrk merged commit 8c6b027 into ziglang:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@der-teufel-programming @andrewrk