Avoid .always_inline to improve debugging experience.
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SystemImpl` wrapper used by convenience functions such as `ADD_SYSTEM` call the user's system update function (`fn_system`) via `@call(.always_inline, ...`. In theory there is no reason not to use `.always_inline` here, but in practice it results in a worse debugging experience as of Zig 0.14.0. For example, on Windows crashes inside `fn_system` are attributed to this `@call`, and it is not possible to set breakpoints on code inside `fn_system`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SystemImplwrapper used by convenience functions such asADD_SYSTEMcall the user's system update function (fn_system) via@call(.always_inline, .... In theory there is no reason not to use.always_inlinehere, but in practice it results in a worse debugging experience as of Zig 0.14.0. For example, on Windows crashes insidefn_systemare attributed to this@call, and it is not possible to set breakpoints on code insidefn_system.