Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP_PICK opcode with tests #45

Closed
wants to merge 1 commit into from

Conversation

KhairallahA
Copy link
Contributor

@KhairallahA KhairallahA commented Sep 16, 2024

No description provided.

@tdelabro
Copy link
Collaborator

ditto of #44
He pushed before you so I'm closing this one.

Sorry it happened, try to coordinate with others on our tg channel

@tdelabro tdelabro closed this Sep 17, 2024
@tdelabro
Copy link
Collaborator

the way to make sure is to check the issues and create one for the opcode you want to add. You will easily see if someone already created the issue

@tdelabro tdelabro reopened this Sep 17, 2024
@tdelabro tdelabro self-requested a review as a code owner September 17, 2024 15:28
@tdelabro
Copy link
Collaborator

actually, you created the issue before him. So I will close #44 instead

@KhairallahA
Copy link
Contributor Author

I was surprised because I check every message on the group haha

@tdelabro
Copy link
Collaborator

tdelabro commented Sep 17, 2024

but your PR seems to be a copy-paste of his, with the weird pickN thing he did.

I will close this one too. Can you please redo the PR without copy-pasting @supreme2580's code?

@tdelabro tdelabro closed this Sep 17, 2024
@KhairallahA
Copy link
Contributor Author

KhairallahA commented Sep 17, 2024

I checked the method used in OP_OVER (#41) and saw that it is close to the implementation so it seems simpler, i just loved @supreme2580 way and used it.

created a new pr #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants