Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/message/mempool #106

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

oxlime
Copy link
Contributor

@oxlime oxlime commented Sep 20, 2024

closes #82
Added mempool.zig, implementing necessary functions to deserialize/serialize into the wire
Added some tests but should look similiar to Verack as neither contain payload.

Copy link
Collaborator

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add it as an if/else condition in wire deserializeMessage

src/network/protocol/messages/mempool.zig Outdated Show resolved Hide resolved
@oxlime
Copy link
Contributor Author

oxlime commented Sep 20, 2024

You should also add it as an if/else condition in wire deserializeMessage

should be good now i just forgot to git add that file.

@oxlime oxlime closed this Sep 20, 2024
@oxlime oxlime deleted the feat/message/mempool branch September 20, 2024 14:04
@oxlime oxlime restored the feat/message/mempool branch September 20, 2024 14:04
@oxlime oxlime deleted the feat/message/mempool branch September 20, 2024 14:05
@oxlime oxlime restored the feat/message/mempool branch September 20, 2024 14:05
@oxlime oxlime reopened this Sep 20, 2024
@oxlime
Copy link
Contributor Author

oxlime commented Sep 20, 2024

You should also add it as an if/else condition in wire deserializeMessage

https://github.com/oxlime/btczee/blob/cae11b088a2b052dc768b84612eb503f81b52005/src/network/wire/lib.zig#L83

@tdelabro
Copy link
Collaborator

oh I missed it sorry

@tdelabro tdelabro merged commit 8561fcb into zig-bitcoin:main Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mempool
2 participants