OP_TOALTSTACK OP_FROMALTSTACK opcodes #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update btczee
feat(p2p): add wire package for messages io (zig-bitcoin#51)
feat(p2p/messages): add verack message (zig-bitcoin#103)
Implemented OP_OVER (zig-bitcoin#59)
|
Hi @tdelabro, can you check this please, I had problems merging in the previous pr and closed it |
tdelabro
requested changes
Sep 20, 2024
Comment on lines
+281
to
+282
| /// # Returns | ||
| /// - `EngineError`: If an error occurs during execution |
There was a problem hiding this comment.
rather than this comment, write the error type in the function signature:
EngineError!void
it will give the same information to the user, more to the compiler, and the language server allow you to jump to the error type
There was a problem hiding this comment.
@tdelabro makes sense, I added EngineError!void
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented OP_TOALTSTACK and OP_FROMALTSTACK for #48