perf: only process visible lines #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natoandro
approved these changes
Aug 8, 2024
michael-0acf4
approved these changes
Aug 8, 2024
luckasRanarison
changed the title
|
I have updated the PR to skip other lines by manually implementing scrolling, so that only visible lines are processed. |
Natoandro
approved these changes
Aug 8, 2024
Synchronize line offsets when switching layout mode.
|
Everything should be ok now, ready for review. |
zifeo
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlighting is done on each draw and it can be expensive on large logs. Highlights can't be cached because we can't store borrowed data, so instead I propose highlighting only visible lines.
We should also consider limiting the buffer size.
Edit:
This could be improved even further by not relying on the scroll function from(Fixed)Paragraphand getting the lines directly, but I'm still trying to figure that out.