feat: patterns highlighting #117
Conversation
feat--pattern-highlighting
src/actors/custom_highlighter.rs
Outdated
| cli::{self, Cli}, | ||
| highlight_processor::HighlightProcessor, | ||
| highlighters, | ||
| theme::{self, processed::Theme}, |
There was a problem hiding this comment.
we usually keep all files in the actors folder as actor, maybe this file can be moved elsewhere?
There was a problem hiding this comment.
Ok, that makes sense. I will move it to the utils module and update my branch.
|
Yeah, I will send the PR to the tailspin repo and wait reply from the maintainers. |
|
I have raised the PR for the tailspin repo here. |
|
I have moved the code to utils file, but I think it's better to move the utils.rs to a new folder and place the highlighter code to separate file which will be under the utils module. I didn't do that cause I didn't wanna change that much of the codebase, but if it's ok, I will. |
|
@destifo go 👍 |
|
I have reorganized the util files under one directory. We will only modify the custom_highlighter when there are changes related to the highlighting in the future. |
|
@destifo wanna terminate that one? seems now possible with bensadeh/tailspin#118 (comment) |
|
Ok, I will update accordingly. |
The highlighting is done by the tailspin crate.