Skip to content

Commit

Permalink
refactor: polish unit tests
Browse files Browse the repository at this point in the history 
Signed-off-by: Zhenchi <[email protected]>
  • Loading branch information
@zhongzc
zhongzc committed Dec 4, 2023
1 parent 63a6fb9 commit 776f9ea
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 31 deletions.
2 changes: 1 addition & 1 deletion src/index/src/inverted_index/search/fst_apply/keys_apply.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ impl KeysFstApplier {
fn get_list(p: &Predicate) -> &HashSet<Bytes> {
match p {
Predicate::InList(i) => &i.list,
_ => unreachable!(), // `in_lists` is filtered by `split_at_in_lists
_ => unreachable!(), // `in_lists` is filtered by `split_at_in_lists`
}
}

Expand Down
59 changes: 29 additions & 30 deletions src/index/src/inverted_index/search/index_apply/predicates_apply.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -134,28 +134,38 @@ mod tests {
metas
}

#[tokio::test]
async fn test_index_applier_apply_point_get() {
// A point get fst applier
fn point_get_fst_applier(value: &'static str) -> Box<dyn FstApplier> {
let mut mock_fst_applier = MockFstApplier::new();
mock_fst_applier
.expect_apply()
.returning(|fst| fst.get("tag0_value0").into_iter().collect());
.returning(move |fst| fst.get(value).into_iter().collect());
Box::new(mock_fst_applier)
}

fn fst_value(offset: u64, size: u64) -> u64 {
(offset << 32) | size
}

fn s(s: &'static str) -> String {
s.to_owned()
}

// A index applier that applies point get "tag0_value0" to tag "tag0"
#[tokio::test]
async fn test_index_applier_apply_point_get() {
// An index applier that point-gets "tag0_value0" on tag "tag0"
let applier = PredicatesIndexApplier {
fst_appliers: vec![("tag0".to_owned(), Box::new(mock_fst_applier))],
fst_appliers: vec![(s("tag0"), point_get_fst_applier("tag0_value0"))],
};

// index reader with a single tag "tag0" and a single value "tag0_value0"
// An index reader with a single tag "tag0" and a corresponding value "tag0_value0"
let mut mock_reader = MockInvertedIndexReader::new();
mock_reader
.expect_metadata()
.returning(|| Ok(mock_metas(["tag0"])));
mock_reader
.expect_fst()
.returning(|meta| match meta.name.as_str() {
"tag0" => Ok(FstMap::from_iter([(b"tag0_value0", (2 << 32) | 1)]).unwrap()),
"tag0" => Ok(FstMap::from_iter([(b"tag0_value0", fst_value(2, 1))]).unwrap()),
_ => unreachable!(),
});
mock_reader.expect_bitmap().returning(|meta, offset, size| {
Expand All @@ -167,15 +177,15 @@ mod tests {
let indices = applier.apply(&mut mock_reader).await.unwrap();
assert_eq!(indices, vec![0, 2, 4, 6]);

// index reader with a single tag "tag0" and without value "tag0_value0"
// An index reader with a single tag "tag0" but without value "tag0_value0"
let mut mock_reader = MockInvertedIndexReader::new();
mock_reader
.expect_metadata()
.returning(|| Ok(mock_metas(["tag0"])));
mock_reader
.expect_fst()
.returning(|meta| match meta.name.as_str() {
"tag0" => Ok(FstMap::from_iter([(b"tag0_value1", (2 << 32) | 1)]).unwrap()),
"tag0" => Ok(FstMap::from_iter([(b"tag0_value1", fst_value(2, 1))]).unwrap()),
_ => unreachable!(),
});
let indices = applier.apply(&mut mock_reader).await.unwrap();
Expand All @@ -184,35 +194,24 @@ mod tests {

#[tokio::test]
async fn test_index_applier_apply_intersection_with_two_tags() {
// A point get fst applier for tag "tag0"
let mut mock_fst_applier = MockFstApplier::new();
mock_fst_applier
.expect_apply()
.returning(|fst| fst.get("tag0_value0").into_iter().collect());
// Another point get fst applier for tag "tag1"
let mut mock_fst_applier2 = MockFstApplier::new();
mock_fst_applier2
.expect_apply()
.returning(|fst| fst.get("tag1_value0").into_iter().collect());

// A index applier that intersects point get "tag0_value0" and "tag1_value0"
// An index applier that intersects "tag0_value0" on tag "tag0" and "tag1_value0" on tag "tag1"
let applier = PredicatesIndexApplier {
fst_appliers: vec![
("tag0".to_owned(), Box::new(mock_fst_applier)),
("tag1".to_owned(), Box::new(mock_fst_applier2)),
(s("tag0"), point_get_fst_applier("tag0_value0")),
(s("tag1"), point_get_fst_applier("tag1_value0")),
],
};

// index reader with two tags "tag0" and "tag1" and a single value "tag0_value0" and "tag1_value0"
// An index reader with two tags "tag0" and "tag1" and respective values "tag0_value0" and "tag1_value0"
let mut mock_reader = MockInvertedIndexReader::new();
mock_reader
.expect_metadata()
.returning(|| Ok(mock_metas(["tag0", "tag1"])));
mock_reader
.expect_fst()
.returning(|meta| match meta.name.as_str() {
"tag0" => Ok(FstMap::from_iter([(b"tag0_value0", (1 << 32) | 1)]).unwrap()),
"tag1" => Ok(FstMap::from_iter([(b"tag1_value0", (2 << 32) | 1)]).unwrap()),
"tag0" => Ok(FstMap::from_iter([(b"tag0_value0", fst_value(1, 1))]).unwrap()),
"tag1" => Ok(FstMap::from_iter([(b"tag1_value0", fst_value(2, 1))]).unwrap()),
_ => unreachable!(),
});
mock_reader.expect_bitmap().returning(|meta, offset, size| {
Expand All @@ -239,7 +238,7 @@ mod tests {
.returning(|| Ok(mock_metas(["tag0"])));

let indices = applier.apply(&mut mock_reader).await.unwrap();
assert_eq!(indices, vec![0, 1, 2, 3, 4, 5, 6, 7]); // scan all
assert_eq!(indices, vec![0, 1, 2, 3, 4, 5, 6, 7]); // full range to scan
}

#[tokio::test]
Expand All @@ -257,7 +256,7 @@ mod tests {
mock_fst_applier.expect_apply().never();

let applier = PredicatesIndexApplier {
fst_appliers: vec![("tag0".to_owned(), Box::new(mock_fst_applier))],
fst_appliers: vec![(s("tag0"), Box::new(mock_fst_applier))],
};

let indices = applier.apply(&mut mock_reader).await.unwrap();
Expand All @@ -275,7 +274,7 @@ mod tests {
mock_fst_applier.expect_apply().never();

let applier = PredicatesIndexApplier {
fst_appliers: vec![("tag0".to_owned(), Box::new(mock_fst_applier))],
fst_appliers: vec![(s("tag0"), Box::new(mock_fst_applier))],
};

let result = applier.apply(&mut mock_reader).await;
Expand Down

0 comments on commit 776f9ea

Please sign in to comment.