Changed SHFQA qachannels/*/oscs/0/freq out-of-range value rounding to…

… match LabOne API
zhinst · Feb 7, 2023 · ddc69f2 · ddc69f2
1 parent 764849f
commit ddc69f2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ Unreleased
    * Changed some `RuntimeError` exceptions to `ToolkitError`.
 * Added `find_zsync_worker_port()` to `PQSC` device class.
   The function can be used to find the ID of the PQSC ZSync port connected to a given device.
+* Changed SHFQA node `qachannels/*/oscs/0/freq` value range from (-500e6 Hz, 500e6 Hz) to (-1e9 Hz, 1e9 Hz). Out-of-range values now rounds
+  to (-1e9 Hz, 1e9 Hz). The functionality is changed to be consistent with LabOne UI.
 
 ## Version 0.5.1
 * Added full support for the following LabOne modules (no need to fallback to zhinst.core):

diff --git a/src/zhinst/toolkit/driver/parsers.py b/src/zhinst/toolkit/driver/parsers.py
@@ -207,12 +207,6 @@ def multiple_of(value: float, factor: float, rounding: str) -> float:
                 lambda v: Parse.greater_equal(v, 0.0),
             ],
         },
-        "qachannels/*/oscs/0/freq": {
-            "SetParser": [
-                lambda v: Parse.smaller_equal(v, 500e6),
-                lambda v: Parse.greater_equal(v, -500e6),
-            ],
-        },
         "qachannels/*/spectroscopy/length": {
             "SetParser": [
                 lambda v: Parse.greater_equal(v, 4),