Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new callback to avoid onActivityResult #293

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add a new callback to avoid onActivityResult #293

wants to merge 6 commits into from

Conversation

junyuecao
Copy link
Contributor

This can simplify the API usage

@ckjoker
Copy link

ckjoker commented Dec 22, 2017

可以具体说下你的这个PR主要是为了解决现有存在的什么问题吗，以及设计思想是什么，只看commit的话不好理解，不知道你想解决什么问题的话，看代码也是云里雾里的~

@junyuecao
Copy link
Contributor Author

junyuecao commented Dec 23, 2017 •
edited
Loading

以前要实现选择图片，需要在onactivityresult里拿到选择的图片，这个PR里我们通过自己构造一个一个隐形的fragment，实现onactivityresult，这样调用方就只需要传一个回调即可。当然原来的API不影响。你可以看下readme里新增的那段代码示例。

@RyugaBahira
Copy link

this should be accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyugaBahira RyugaBahira RyugaBahira approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junyuecao @ckjoker @RyugaBahira