Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heck crate to 0.5 #467

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Dec 13, 2024

No description provided.

@zhiburt
Copy link
Owner

zhiburt commented Dec 15, 2024

Thanks for commitment @marxin
Have a great week, and happy new year (I hope not too soon 😄)
Take care.

@zhiburt zhiburt merged commit 5e4bdbf into zhiburt:master Dec 15, 2024
71 of 75 checks passed
@marxin marxin deleted the update-heck-crate branch December 15, 2024 15:34
@marxin
Copy link
Contributor Author

marxin commented Dec 15, 2024

Thanks for the review. Speaking about the next release, when can I expect a new one?

@zhiburt
Copy link
Owner

zhiburt commented Dec 15, 2024

Speaking about the next release, when can I expect a new one?

Well to be honest I don't know,
generally each one contained some major thing.

I could make a patch bump and release these.
But it would be also not ideal, I guess.

I think need to think :) whether there's some things which could be improved/added.
Currently I have nothing in my mind.

Except to test a R-tree vs a list of HashTable for settings we have now. I was pondering about it maybe a year ago maybe even longer, but decided that current approach is better.

Essentially we have many calls like these, which I still hope to optimize somehow.....

if hm.get(Cell) {}
or else hm.get(Row) {}
or else hm.get(Column) {}
or else hm.get(Global) {}

@zhiburt
Copy link
Owner

zhiburt commented Dec 15, 2024

I've just had some examples to run; and it seems promising.
So yes I will try to get a proper impl/testing and see.

And if it's cool we will do it this week or next.
But we will hope to cover it this year 😄 (I just often miss....these deadlines)

@marxin
Copy link
Contributor Author

marxin commented Dec 16, 2024

Good! Anyway, I would appreciate a new release, but I understand you have other stuff to do before making a proper release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants