Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to syn 2 #466

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Update to syn 2 #466

merged 1 commit into from
Dec 15, 2024

Conversation

wyatt-herkamp
Copy link
Contributor

@wyatt-herkamp wyatt-herkamp commented Dec 12, 2024

Updates to syn 2.0

Note that the expr_lit_to_string function now returns an error. A CString cannot be turned into a String, without possible error. I'm not sure how you wanted this to be handled. Also, it is nonexhaustive now.

Also closes #313

@zhiburt
Copy link
Owner

zhiburt commented Dec 12, 2024

Hi @wyatt-herkamp

I'll look into it tomorrow.
Thanks a lot.

I want to let you know,
You are probably the first person, who properly updates CHANGELOG.md 😅
Even I struggle with it, allthough always do think about it....

Anyhow, I'll check it tomorrow,
But if I won't reach out then,
Have a great weekend.

@zhiburt
Copy link
Owner

zhiburt commented Dec 15, 2024

Note that the expr_lit_to_string function now returns an error. A CString cannot be turned into a String, without possible error. I'm not sure how you wanted this to be handled. Also, it is nonexhaustive now.

Good.
Thanks for your @wyatt-herkamp commitment.

Take care.
And happy new year.

@zhiburt zhiburt merged commit 74e280d into zhiburt:master Dec 15, 2024
69 of 75 checks passed
@wyatt-herkamp wyatt-herkamp deleted the syn-2 branch December 15, 2024 18:06
@marxin
Copy link
Contributor

marxin commented Jan 6, 2025

Hey, happy new year. I am just wondering if we can expect a new release soon? Thank you.

@zhiburt
Copy link
Owner

zhiburt commented Jan 6, 2025

As always I am late 😞

I am working on some inner refactoring to reduce boilerplate. (hope to cover it by tomorrow; got pretty neat design)
And also has an intent to add #472, did a few patchworks but yet not completed.
And then I do plan to release it....

It's not a lot of work to be candor, so it's got to be soon but IDK maybe by next week

@marxin
Copy link
Contributor

marxin commented Jan 8, 2025

Don't worry, it's fine! It works for me if the release happens in the upcoming weeks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants