Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Clone, Copy to tabled::settings::object::Cell #406

Merged
merged 1 commit into from
Jun 12, 2024
Merged

add Clone, Copy to tabled::settings::object::Cell #406

merged 1 commit into from
Jun 12, 2024

Conversation

Alexdelia
Copy link
Contributor

also update papergrid Position derive

@zhiburt
Copy link
Owner

zhiburt commented Jun 12, 2024

Yes; was missed.

Thanks.

Take care

@zhiburt zhiburt merged commit bc92ae4 into zhiburt:master Jun 12, 2024
64 of 75 checks passed
@Alexdelia Alexdelia deleted the fix/object/Cell/Copy branch June 13, 2024 13:22
@Alexdelia
Copy link
Contributor Author

Alexdelia commented Jun 18, 2024

@zhiburt my bad!

https://github.com/zhiburt/tabled/pull/406/files#diff-6cf2d635d9e21ba2e27b76757a18797d07598c9076b6fe41d9ab323bd67019d1R13

is incorrect, we cannot apply derive to a type

it compiled because tabled is using the crate registry version of papergrid, and not the local one

@zhiburt
Copy link
Owner

zhiburt commented Jun 18, 2024

is incorrect, we cannot apply derive to a type

Yes 😄
To be honest I was thinking about it; and decided not to check; was thinking maybe something was changed in a latest rust versions :)

it compiled because tabled is using the crate registry version of papergrid, and not the local one

True;;;;;;;;
Kind of thinking about it too; in a different way; to split workspace into its own modules; to speed up compile time.
But haven't got to a conclusion which is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants