Added force string type to 3rd argument of preg_replace in util::log()
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…()` which would otherwise throw a deprecated error for passing `null` in certain instnaces. For example, attempting to omit the `cardCode` value on "Stored Card" transaction where the card code is not known, while SDK logging is enabled, would cause the affected line to attempt to perform `preg_replace` on a null value when parsing the card code value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added force string type to 3rd argument of preg_replace in
util::log()which would otherwise throw a deprecated error for passingnullin certain instances. For example, attempting to omit thecardCodevalue on "Stored Card" transaction where the card code is not known, while SDK logging is enabled, would cause the affected line to attempt to performpreg_replaceon a null value when parsing the card code value.