Allow specifying UTC vs local timezone as program argument #77
Conversation
src/zfs-auto-snapshot.sh
Outdated
| @@ -209,7 +211,7 @@ do_snapshots () # properties, flags, snapname, oldglob, [targets...] | |||
|
|
|||
| GETOPT=$(getopt \ | |||
| --longoptions=default-exclude,dry-run,fast,skip-scrub,recursive \ | |||
| --longoptions=event:,keep:,label:,prefix:,sep: \ | |||
| --longoptions=event:,keep:,label:,prefix:,local-tz:,sep: \ | |||
There was a problem hiding this comment.
The : after local-tz needs to be removed because this option doesn't take an argument. I'd also suggest moving it down in to the next line.
src/zfs-auto-snapshot.sh
Outdated
| DATE=$(date --utc +%F-%H%M) | ||
| # If the --local-tz flag is set use the system's timezone. | ||
| # Otherwise, the default is to use UTC. | ||
| if [ -n $"opt_local_tz" ] |
There was a problem hiding this comment.
The $ should be moved inside the quotes.
|
Fixed - thank you. |
|
I added |
|
Any plans to merge this? I'd really like to keep my snapshots in local time. |
|
How has this not been merged yet? I recently started using zfs-auto-snapshot and have found it really annoying that the snapshot names are all in UTC without any mention of UTC at all! For me times are off by 5 hours. Imagine I have this script set to run at midnight, but something bad happened at 11pm. The next morning I catch the error and want to rollback snapshots.. oh but wait the most recent one is labeled 5am, well after the bad thing occurred at 11pm, guess I need to rollback even further. How is this acceptable? I'll be manually patching my local script with this PR but strongly urge that this PR be accepted for the sanity of users everywhere. |
|
Please merge this for the love of all of us who don't want to do UTC calculations on our snapshots. :) |
|
Any plans to merge this? |
|
Please merge this, it's rather troublesome having to add 8 hours to timestamps manually every time... |
|
Would also love to see this merged. We give end users access to their snapshots; confusion abounds over time stamps not matching local time. |
|
A workaround is to use $ crontab -e
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
10,20,30,40,50 * * * * faketime "+8 hours" zfs-auto-snapshot -q -g --label=10minutely --keep=24 //
0 1-23 * * * faketime "+8 hours" zfs-auto-snapshot -q -g --label=hourly --keep=24 //
0 0 2-7,9-14,16-21,22-31 * * faketime "+8 hours" zfs-auto-snapshot -q -g --label=daily --keep=7 //
0 0 8,15,22 * * faketime "+8 hours" zfs-auto-snapshot -q -g --label=weekly --keep=4 //
0 0 1 * * faketime "+8 hours" zfs-auto-snapshot -q -g --label=monthly --keep=4 // |
|
Made a fork to use this and other PRs, and while at it, I checked other forks to see if there's anything interesting to gather. It's funny that most of them were simple forks that removed the |
No description provided.