-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CMSShape PDF #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, that's the right direction. Docs, (serialization), tests, but you know all that. And as discussed, feel free to add numba-stats as a dependency, that makes sense to test against
Co-authored-by: Jonas Eschle <[email protected]>
@jonas-eschle I'm happy with the current state and testing. Please review it when you got some time. |
Looks good (minus minor things), and you reminded me to also increase the visibility of zfit-physics |
Co-authored-by: Jonas Eschle <[email protected]>
@jonas-eschle Alright, let the tests run and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've just fixed two minor doc things: there was a piece of string laying around in the code and I've converted the docs from MD to RST, which is usually used in Python docstrings (afaik).
Thanks, I saw md in the relativistic breit wigner implementation so I just followed that. Thanks for removing the string that was lying around, I had forgotten it. Merge it whenever you want! |
Starting a PR to add the CMSShape PDF into zfit-physics.
Related to zfit/zfit#512
Proposed Changes
Tests added
tests/test_pdf_cmsshape.py
Checklist