Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CMSShape PDF #63

Merged
merged 11 commits into from
Mar 15, 2024
Merged

feat: add CMSShape PDF #63

merged 11 commits into from
Mar 15, 2024

Conversation

ikrommyd
Copy link
Contributor

@ikrommyd ikrommyd commented Mar 14, 2024

Starting a PR to add the CMSShape PDF into zfit-physics.
Related to zfit/zfit#512

Proposed Changes

  • Implement CMSShape

Tests added

  • tests/test_pdf_cmsshape.py

Checklist

  • change approved
  • implementation finished
  • correct namespace imported
  • tests added
  • CHANGELOG updated

Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, that's the right direction. Docs, (serialization), tests, but you know all that. And as discussed, feel free to add numba-stats as a dependency, that makes sense to test against

zfit_physics/models/pdf_cmsshape.py Show resolved Hide resolved
zfit_physics/models/pdf_cmsshape.py Show resolved Hide resolved
@ikrommyd ikrommyd requested a review from jonas-eschle March 15, 2024 11:49
@ikrommyd
Copy link
Contributor Author

@jonas-eschle I'm happy with the current state and testing. Please review it when you got some time.

requirements_dev.txt Outdated Show resolved Hide resolved
@jonas-eschle
Copy link
Contributor

Looks good (minus minor things), and you reminded me to also increase the visibility of zfit-physics

@ikrommyd
Copy link
Contributor Author

@jonas-eschle Alright, let the tests run and merge.

Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've just fixed two minor doc things: there was a piece of string laying around in the code and I've converted the docs from MD to RST, which is usually used in Python docstrings (afaik).

@ikrommyd
Copy link
Contributor Author

ikrommyd commented Mar 15, 2024

Looks good! I've just fixed two minor doc things: there was a piece of string laying around in the code and I've converted the docs from MD to RST, which is usually used in Python docstrings (afaik).

Thanks, I saw md in the relativistic breit wigner implementation so I just followed that. Thanks for removing the string that was lying around, I had forgotten it. Merge it whenever you want!

@jonas-eschle jonas-eschle merged commit 1b431ca into zfit:develop Mar 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants