Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More information in JoinSubmissionPane #1198

Merged
merged 6 commits into from
Dec 7, 2020
Merged

More information in JoinSubmissionPane #1198

merged 6 commits into from
Dec 7, 2020

Conversation

richardolsson
Copy link
Member

This PR makes the following changes to JoinSubmissionPane:

image

image

@richardolsson
Copy link
Member Author

The PR also introduces a "new" set of translations in misc.fields, which includes translations of native fields. This is not used anywhere else yet, and there are also some other DRY issues with fields that I have created a separate issue for, see #1197.

niklasva82
niklasva82 requested changes Dec 4, 2020
View reviewed changes
src/components/panes/JoinSubmissionPane.jsx Outdated Show resolved Hide resolved
src/components/panes/JoinSubmissionPane.jsx Outdated Show resolved Hide resolved
@richardolsson
Copy link
Member Author

Fixed the nextProps issue. Please review again! :)

niklasva82
niklasva82 requested changes Dec 4, 2020
View reviewed changes
Copy link
Member

@niklasva82 niklasva82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of issues related to loading of resources. It still works but errors are logged to the console due to this.

src/components/panes/JoinSubmissionPane.jsx Outdated Show resolved Hide resolved
src/components/panes/JoinSubmissionPane.jsx Show resolved Hide resolved
@richardolsson
Copy link
Member Author

I've pushed fixes to the issues you found now @niklasva82. Please re-review again. :)

niklasva82
niklasva82 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@niklasva82 niklasva82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Everything seems to work fine now and no errors. Code looks good too.

@richardolsson richardolsson merged commit fab0f45 into master Dec 7, 2020
@richardolsson richardolsson deleted the enhancement/full-join-sub-data branch December 7, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasva82 niklasva82 niklasva82 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All form fields in join submission pane
2 participants
@richardolsson @niklasva82