Make sure we have pulled before reading LyraConfig #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WULCAN
force-pushed
the
undocuented/centralize_initial_pull
branch
from
8c3eb3e to
47d9ea2
Compare
Move all initializing git pull into RepoGit and make RepoGit shared for each unique local git clone. As the repository specific configuration file is potentially stale, we need to do this initializing pull before any read of that configuration file. To ensure that, I replace all direct reads with a read through RepoGit. Since the factory always pulls, we know the config will be fresh after a Lyra server start. Note that the route for creating pull-requests can now theoretically pull twice, if RepoGit was not initialzied first. That is however extremely unlikely as button the create pull requests is on a page that uses RepoGit to load its data. Anyway, I beleive we will resolve this when we implement resyncing from the remotes.
WULCAN
force-pushed
the
undocuented/centralize_initial_pull
branch
from
47d9ea2 to
e0c168f
Compare
amerharb
reviewed
Mar 23, 2024
webapp/src/app/api/translations/[projectName]/[lang]/[msgId]/route.ts
Outdated
Show resolved
Hide resolved
This reverts commit 08e5b4d.
…ll/small_change Undocumented/centralize initial pull/small change
richardolsson
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all initializing git pull into RepoGit and make RepoGit shared for each unique local git clone.
As the repository specific configuration file is potentially stale, we need to do this initializing pull before any read of that configuration file. To ensure that, I replace all direct reads with a read through RepoGit. Since the factory always pulls, we know the config will be fresh after a Lyra server start.
Note that the route for creating pull-requests can now theoretically pull twice, if RepoGit was not initialzied first. That is however extremely unlikely as button the create pull requests is on a page that uses RepoGit to load its data. Anyway, I beleive we will resolve this when we implement resyncing from the remotes.