231221 remove error logging #37
Conversation
| error: err, | ||
| info: () => {}, | ||
| debug: debug, | ||
| error: () => {}, |
There was a problem hiding this comment.
a bit not sure about this if it will will mute github package when there is an error
There was a problem hiding this comment.
I think error handling is not a matter of logging so it should be handled elsewhere altogether IMO.
| @@ -11,18 +12,17 @@ export async function GET() { | |||
| const msgAdapter = MessageAdapterFactory.createAdapter(config); | |||
| const messages = await msgAdapter.getMessages(); | |||
|
|
|||
| // TODO: change data instruction to be a map of key to value, instead of object | |||
There was a problem hiding this comment.
remove it cuz the current format looks ok, and I can't remember why I add this TODO.
amerharb
force-pushed
the
231221-remove-error-loggin
branch
from
f800a82 to
77cbdd0
Compare
amerharb
force-pushed
the
231221-remove-error-loggin
branch
from
77cbdd0 to
741954e
Compare
There was a problem hiding this comment.
This looks good!
Doess this fully resolve issue #32 or is there some logging remaining elsewhere?
| error: err, | ||
| info: () => {}, | ||
| debug: debug, | ||
| error: () => {}, |
There was a problem hiding this comment.
I think error handling is not a matter of logging so it should be handled elsewhere altogether IMO.
|
I notice this PR is still in draft mode. Is that intentional? |
|
Remove error logging
related to issue: #32