Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check formatting in CI #31

Merged
merged 5 commits into from
Dec 17, 2023

Conversation

richardolsson
Copy link
Member

@richardolsson richardolsson commented Dec 17, 2023

This PR introduces a formatting check using prettier in the CI actions.

Don't merge this until #28 has been merged.

@richardolsson richardolsson force-pushed the undocumented/formatting-in-ci branch from f63e2d2 to 3eb4392 Compare December 17, 2023 05:56
@richardolsson richardolsson mentioned this pull request Dec 17, 2023
Copy link
Collaborator

@amerharb amerharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
can we later or at some point move the README to the root folder?

@amerharb amerharb merged commit b157232 into undocumented/store-refactor Dec 17, 2023
1 check passed
@amerharb amerharb deleted the undocumented/formatting-in-ci branch December 17, 2023 09:19
@richardolsson
Copy link
Member Author

Great! can we later or at some point move the README to the root folder?

Funny that you mention that, because I actually started writing a README for the root folder, which is separate from the README for the web app. Let's talk about such things after our workshop in Tuesday! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants