Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uuid snippet to branch name #132

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Add uuid snippet to branch name #132

merged 4 commits into from
Sep 29, 2024

Conversation

a-jaxell
Copy link
Collaborator

@a-jaxell a-jaxell commented Sep 28, 2024

Add UUID snippet to PR generation

This adds a UUID snippet instead of a date string to the generated branch name used in the PR automation.

Background

Theoretically multiple branches with the same name could be created when using a string of Date.now() formatted as YYYY-mm-dd-hh:mm:ss as postfix to the branch submitted with the PR.

resolves #57

@a-jaxell a-jaxell requested a review from WULCAN September 28, 2024 15:50
@WULCAN WULCAN self-assigned this Sep 29, 2024
Copy link
Collaborator

@WULCAN WULCAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I only have one small request, see the unresolved conversation below.

webapp/src/actions/createPullRequest.ts Show resolved Hide resolved
webapp/src/actions/createPullRequest.ts Outdated Show resolved Hide resolved
@amerharb amerharb requested review from WULCAN and amerharb September 29, 2024 08:53
@WULCAN WULCAN merged commit c19ca9e into main Sep 29, 2024
2 checks passed
@WULCAN WULCAN deleted the issue-57-uuid-in-branch-name branch September 29, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pull request branch names could theoretically collide
3 participants