Extract data access layer #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First access data, then extract props.
First access data, then extract props.
* Destructure parameter directly * Infer type variable to fit long line
Use expression body instead of block body.
* Shorter parameter and property names * Inline constants * Use expression body
amerharb
reviewed
Aug 17, 2024
MDN uses a captial F in its name for the parameter.
Instantiating objects with new can be a little ambigious. For example new X().Y() is either creating a new instance with X as a constructor or with Y as a constructor. Being nameable, factory functions are also better than constructors when you want to offer multiple different signatures for creating instances.
It is more important to highlight that the field has a different type than that the field too contains promises.
amerharb
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I want the data access layer just for the overview of the interactions with server state.
This change set contains some first steps towards a data access layer. I would like it reviewed before I continue as there are multiple small but non-trivial decisions made.
I recommend review commit-by-commit and consulting the commit messages for more detail.