Enable keyboard navigation with the tab key #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #263 and #264. The reason for bundling fixes for two issues in one pull request is that one of the fixes is walking back a previous fix and I don't want to reintroduce the original bug, so atomically fixing both in one merge seems better!
App.jsxPaneBase.jsxReportPane.jsxSo this first fixes #263 by walking back the fix to #104 in
App.jsx. It then fixes both #264 and #104 simultaneously with the changes toPaneBase.jsxandReportPane.jsx.Comprehensive details are available on the issues themselves so I won't duplicate any of that here. Instead here's a screen recording demonstrating the behaviour of this change to the code. In it, I use the newly re-enabled keyboard navigation to open a call page (#263), then I tab all the way through the UI repeatedly without triggering the unwanted premature focusing of the report pane (#264).
Let me know what you think!