fix: Prevent empty titles for Areas to be saved #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also provides a fallback presentation in case the area has previously been updated with an empty title.
ajoensson
force-pushed
the
untracked/empty-canvass-area-title
branch
from
e43d31e to
1d1b986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates areas with the default "Untitled area" title if a user tries to save an area with an empty title. Also provides a fallback presentation in case the area has previously been updated with an empty title.
Screenshots
Old behaviour: (it does not seem to be possible to even correct this mistake)
Fixed behaviour:
Entering an empty string as title
Falling back to "Untitled area"
Changes
Notes to reviewer
–
Related issues
This was an untracked bug, as far as I could tell