Introduce deadzone around MapControls #2560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on inaccurate taps
ajoensson
force-pushed
the
issue-2549/map-controls-deadzone
branch
from
fe21ab2 to
777ee5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a deadzone around the
MapControls-component. This deadzone is there to prevent inaccurate clicks or taps (which is more likely on touch devices) to accidentally interact with the map, which could cause accidental pans or zooms.Screenshots
Highlighting the (green) padding, which is acting as the deadzone, using the Chrome inspector:
Changes
MapControls, creating an area that is noninteractive ("deadzone")MapControlsappear on the same place as before these changes.Notes to reviewer
It is not entirely sure that this is the correct way to solve this issue. See the discussion in the related issue, before merging this PR!
Related issues
Resolves #2549 (well, maybe)