Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizer Map: Split up map into multiple layers and components #2553

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

k-nut
Copy link
Collaborator

@k-nut k-nut commented Feb 9, 2025

Description

This is a proposal for some refactoring based on the work that I started in #2530. When I was working on that task, I found it a bit difficult to understand how the map is structured. In this change I split the content of the map into layers and components.

Everything should still look and behave as it did before.

Changes

  • The first commit pulls the three distinct things that we show (areas, center markers and individual markers) into three distinct leaflet FeatureGroups
  • The second commit splits the markers in the center of the areas (the overlay markers) into separate components to reduce nesting

Notes to reviewer

This is based on the changes in #2530, it probably makes sense to only look at this after merging the other PR.

@k-nut k-nut force-pushed the issue-2445/split-up-layers branch from cf76580 to fe86026 Compare February 10, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant