Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZuiEditor frame #2543

Open
wants to merge 28 commits into
base: undocumented/bugs-in-zui-editor
Choose a base branch
from
Open

ZuiEditor frame #2543

wants to merge 28 commits into from

Conversation

ziggabyte
Copy link
Contributor

@ziggabyte ziggabyte commented Feb 6, 2025 •
edited
Loading

This PR places the new ZuiEditor in the /compose tab of an email page. It also adds UI to see the outline of an email.

Adds

  • EditorOutline component
  • Outlines and messages when there are errors in a block
  • Serialisation/deserialisation and tests
  • The ZuiEditor into the /compose tab

Removes

  • All code related to the old editor

To reviewer
Please do play around with this. There are plenty of things documented in pink posits in Miro, but please add to those if you find things that are not there.

@ziggabyte ziggabyte marked this pull request as draft February 6, 2025 08:54
@ziggabyte
Add alt and fileId attributes to ImageExtension.
ccdd955
@ziggabyte
Create tested function to transform content of header and paragraph b…
39b3b5b 
…locks into our InlineNode format.
@ziggabyte
Create tested function to turn remirror editor content into our zetki…
85027c7 
…n email content format.
@ziggabyte
Update a few types.
c0e6a5b
@ziggabyte
Create tested function to turn inline nodes into remirror format.
ab1cf4c
@ziggabyte
Create tested function to turn zetkin block format into remirror bloc…
ce0ea57 
…k format.
@ziggabyte
Create util type guard function.
17c4edd
@ziggabyte
Create tested function to determine block problems.
e604510
@ziggabyte
Use math.random instead of crypto UUID.
aedba68
@ziggabyte
Rename function.
37904d0
@ziggabyte
Make EmailOutline component that displays one list item per editor bl…
2f4e377 
…ock.
@ziggabyte
Add test for default button text.
f9ef80a
@ziggabyte
Gray background colour on item in outline that represents the current…
8fa8269 
…ly selected block.
@ziggabyte
Delete everything related to the old email editor.
e987a12
@ziggabyte
Update to use new editorBlockProblems function.
bb72b3b
@ziggabyte
Move the new editor into the Compose page.
102e14a
@ziggabyte
Remove tab used in development of new editor.
783fbff
@ziggabyte
Add border between the outline and editor.
712be9c
@ziggabyte
Show outline and message around blocks with errors.
cbd0af7
@ziggabyte
Take empty blocks into consideration when calculating problems.
91eb5e5
@ziggabyte
Change icon in button block toolbar.
ff5b453
@ziggabyte
Fix growing container issue on block list items.
a4fc777
@ziggabyte
Place selection outline underneath error outline.
97881d6
@ziggabyte
Only show insert line if mouse is inside editor.
712574d
@ziggabyte ziggabyte changed the title WIP for Victor ZuiEditor frame Feb 13, 2025
@ziggabyte ziggabyte marked this pull request as ready for review February 13, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardolsson richardolsson Awaiting requested review from richardolsson

@Bagera Bagera Awaiting requested review from Bagera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ziggabyte