-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event title to event page header #2261
Add event title to event page header #2261
Conversation
types: eventTypes, | ||
<> | ||
<Head> | ||
<title> {eventFuture.data?.title} </title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I believe I forgot to tell you. If there is no title, the title should use the activity title, and if that's not available, it should use the noTitle message (e.g. Untitled event)
Here is an example of how this is implemented:
{event.title || event.activity?.title || messages.common.noTitle()} |
6b389e1
to
49b9245
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution looks good! But the CI isn't passing because the code formatting does not follow the "Prettier" code style. Please try running yarn prettier --write src
and then commit the changes.
Adjusting formatting of code
cdf9046
to
e5fa8bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I have tried the preview build, and also reviewed the code (thank you GitHub for the beautiful "Hide whitespace" feature) and it all looks good.
Lets get this merged! 💯
Congratulations on your first(?) code contribution to Zetkin! 🎉
Description
Adding the event title to the page title
Screenshots
Changes
Title added to event header
Notes to reviewer
Verify that the event page is showing the event page title (instead of the address)
Related issues
Resolves #2258