Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event title to event page header #2261

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

dev-di
Copy link
Contributor

@dev-di dev-di commented Oct 13, 2024

Description

Adding the event title to the page title

Screenshots

image

Changes

Title added to event header

Notes to reviewer

Verify that the event page is showing the event page title (instead of the address)

Related issues

Resolves #2258

types: eventTypes,
<>
<Head>
<title> {eventFuture.data?.title} </title>
Copy link
Member

@niklasva82 niklasva82 Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I believe I forgot to tell you. If there is no title, the title should use the activity title, and if that's not available, it should use the noTitle message (e.g. Untitled event)

Here is an example of how this is implemented:

{event.title || event.activity?.title || messages.common.noTitle()}

Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good! But the CI isn't passing because the code formatting does not follow the "Prettier" code style. Please try running yarn prettier --write src and then commit the changes.

Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I have tried the preview build, and also reviewed the code (thank you GitHub for the beautiful "Hide whitespace" feature) and it all looks good.

Lets get this merged! 💯

Congratulations on your first(?) code contribution to Zetkin! 🎉

@richardolsson richardolsson merged commit 112995d into zetkin:main Oct 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events: "title" missing on event pages
3 participants