change messages in button menu #2250
Conversation
|
Nice work! Would love to merge, but there's a conflict. Are you able to resolve it (or optionally, pull the latest main and reapply your work in a new branch and a new PR)? |
|
Damn am I rusty … Will fix conflict. |
…pp.zetkin.org into issue-2241/activity-creation-ui
There was a problem hiding this comment.
Nice work sorting the merge conflict!
I've tried the preview build, and I'm afraid it's not working. The old strings are still being rendered in the UI. This is probably because the en.yml file contains the old translations.
This highlights a problem with changing the default text for a message (in messageIds.ts) that I didn't think about when I first saw the PR. If we just update the default text, translators will not know that they need to update the localized strings.
The best thing to do would be to move the messages to get another name. Which makes sense for another reason as well. It's kind of weird that these messages are in some arbitrarily named linkGroup scope, alongside public and settings which are not part of the same drop-down.
Maybe they can be added to a separate group called something like createButton next to linkGroup (but beware of alphabetical order)?
|
Sure! |
|
I squashed and merged, so that all of the commits in this PR are "compacted" into a single commit in |
Description
This PR shortens overtly expressive messages relating to the Create Activity button.
Changes
Changes the text of the Create Activity button to "Create"
Changes the "Create" menu item messages from "Create [activity]" to "[activity]"
Related issues
Resolves #2241