Issue 2084/activity list items layout - adding subtitles #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardolsson
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Nice work @neta-kedem!
I'll take a closer look at the code, but the first thing I noticed when I tried the preview build is that the stats have moved out of alignment.
This is what an activity list looks like on main (running on app.dev.zetkin.org):
Below is what it looks like in the preview build for this branch. Note how the little numeric chips are no longer aligned along the same vertical line.
Can you take a look at this before a more thorough review of the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds subtitles to activity list items, and makes minor UI changes to show it
Screenshots
Changes
Notes to reviewer
not fully polished, but it's working so I'm pushing for the demo
Related issues
Resolves #2084