chore: Bump download-artifact to v4 #3104
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the GitHub Actions workflow in Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
CryptoFewka
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/actions/upgrade-testing/action.yml (1)
Line range hint
1-89: Verify environment variable configurationThe extensive environment configuration remains unchanged, which is good for maintaining stability. However, there are some commented-out variables that might need attention:
BINARY_DOWNLOAD_LISTTAG_LISTEND_VERSIONConsider documenting why these are commented out or remove them if they're no longer needed.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/actions/upgrade-testing/action.yml(1 hunks)
🔇 Additional comments (1)
.github/actions/upgrade-testing/action.yml (1)
17-20: LGTM: Proactive update to download-artifact@v4
The update is well-timed considering the upcoming deprecation of v3 on November 30, 2024. The inline comment provides clear context for the change.
Let's verify the compatibility of v4 with the current workflow:
✅ Verification successful
✓ Verified: Single instance of download-artifact, update is safe
The codebase scan reveals this is the only instance of actions/download-artifact usage, making this a straightforward and isolated update. The change from v3 to v4 in this composite action poses minimal risk as:
- No other workflows depend on this action
- The update is contained within a single composite action
- The change maintains the same input parameters (
nameandpath)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if there are any breaking changes in download-artifact@v4
# that might affect our workflow
# Check if the workflow has been tested with v4
gh run list --workflow="upgrade-testing" --json conclusion,headSha \
--jq '.[] | select(.headSha=="'$GITHUB_SHA'") | .conclusion'
# Look for any issues related to download-artifact in recent runs
gh run list --workflow="upgrade-testing" --json conclusion,headSha,url \
--jq '.[] | select(.conclusion=="failure") | .url' | \
xargs -I {} gh api {} | jq -r '.jobs[].steps[] | select(.name | contains("download-artifact")) | .conclusion'
Length of output: 454
Script:
#!/bin/bash
# Let's verify the changes by checking:
# 1. Other workflows using download-artifact to ensure consistency
# 2. Any related configuration or setup files
# 3. Documentation updates if any
# Find all workflow files using download-artifact
rg -l "actions/download-artifact" .github/
# Check the specific versions being used
rg "actions/download-artifact@v\d" .github/
# Look for any related documentation or configuration
fd -t f "README|CONTRIBUTING|CHANGELOG" -E "*.md"
Length of output: 339
|
This action appears to no longer be used, and can likely just be deleted. |
|
@zeta-chain/devops please needs one review |
Description
This PR bumps the download-artifacts action to v4, ahead of its deprecation on November 30, 2024.
How Has This Been Tested?
Summary by CodeRabbit
download-artifactaction, ensuring future compatibility.