ci: Add listen.dev to Github Actions #3059
Conversation
📝 WalkthroughWalkthroughA new GitHub Actions workflow named Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
jkan2
changed the title
jkan2
changed the title
|
The listen.dev eavesdropping engine didn't spot any critical runtime threat.
Congrats, you're safe! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
.github/workflows/lstn.yml (3)
1-8: Consider refining the workflow triggersThe current trigger configuration might be too broad. Consider limiting pull request triggers to specific target branches (e.g.,
develop,main) to avoid unnecessary runs.pull_request: + branches: + - develop + - main
13-15: Improve condition readability and fix formattingThe conditional logic is correct but could be more readable. Also, there's a trailing space on line 15.
- if: | - github.actor != 'dependabot[bot]' && - (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'zeta-chain/node') + if: > + github.actor != 'dependabot[bot]' && + ( + github.event_name != 'pull_request' || + github.event.pull_request.head.repo.full_name == 'zeta-chain/node' + )🧰 Tools
🪛 yamllint
[error] 15-15: trailing spaces
(trailing-spaces)
16-24: Fix formatting issuesSeveral formatting issues need to be addressed:
- Incorrect indentation in steps section
- Trailing spaces
- Missing newline at end of file
steps: - - name: Checkout repository - uses: actions/checkout@v4 - - - name: Run listen.dev Scan - uses: listendev/[email protected] - with: - jwt: ${{ secrets.LSTN_API_KEY }} - ci: only + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Run listen.dev Scan + uses: listendev/[email protected] + with: + jwt: ${{ secrets.LSTN_API_KEY }} + ci: only +🧰 Tools
🪛 yamllint
[warning] 17-17: wrong indentation: expected 6 but found 4
(indentation)
[error] 19-19: trailing spaces
(trailing-spaces)
[error] 22-22: trailing spaces
(trailing-spaces)
[error] 24-24: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/lstn.yml(1 hunks)
🧰 Additional context used
🪛 yamllint
.github/workflows/lstn.yml
[error] 15-15: trailing spaces
(trailing-spaces)
[warning] 17-17: wrong indentation: expected 6 but found 4
(indentation)
[error] 19-19: trailing spaces
(trailing-spaces)
[error] 22-22: trailing spaces
(trailing-spaces)
[error] 24-24: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
.github/workflows/lstn.yml (1)
20-24: Verify secret configuration and consider version pinning
The workflow depends on the LSTN_API_KEY secret. Also, consider pinning to an exact version of the listen.dev action for better security.
🧰 Tools
🪛 yamllint
[error] 22-22: trailing spaces
(trailing-spaces)
[error] 24-24: no new line character at the end of file
(new-line-at-end-of-file)
There was a problem hiding this comment.
It's not clear what purpose this tool actually serves? From their website:
See and control every external connection your builds make to catch malicious behavior before it reaches production.
But this isn't integrated into any of the build/test workflows so you won't really see anything?
Description
Adds a new security tool (listen.dev) to github actions.
note: this needs to be merged for it to work see this as I used this repo testing. It only works when it was already merged in
main.How Has This Been Tested?
Summary by CodeRabbit
New Features
listen.devapplication, enhancing security measures during development.Chores