ZPM UI overhaul (WIP) #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is better than having a "false" file (specified as `- ""`). This created an error with a stacktrace if the user tries to do `zpm new`, immediately followed by `zpm bundle`. Now, if the user tries to bundle an "empty" project, they get a more meaningful error message.
The `zapp` variable wasn't being provided to the template rendering, and thus was failing. There was also an issue with `auth_opts` not rendering correctly.
|
FYI, there are bugs with this during deployment (if there is no UI). I need to do some more testing. |
| @@ -316,9 +352,6 @@ def bundle_project(root): | |||
| " the zapp.yaml matched anything." | |||
| ) | |||
|
|
|||
| if not zapp.get('ui'): | |||
| _add_ui(tar, zapp) | |||
There was a problem hiding this comment.
I believe this was the last caller of _add_ui.
There was a problem hiding this comment.
Okay, I'll remove it. Good catch!
For version 1.0 auth, for example, we were expecting the version to be given as '1.0'. I found a real-world case where it was just '1' instead, and it pretty much broke the auth option rendering in the UI template.
|
@mgeisler I made some updates to this branch, can you please take a look? |
|
Merged as it already looked good before the final two fixes you made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109.