Test with all supported node versions

[rotu]

The package nominally supports node 10 and later. Run CI with all supported node even versions.

[rotu]

node 12 is not compatible with [email protected]
node 14 fails in [email protected] nodejs/node-gyp#2947
node 16 fails from the newly introduced [email protected] which relies on addAbortListener, which was introduced in node 18.

I think it's reasonable to cut support for Node < v18.18.0 and < v20.5.0. @aminya, thoughts?

[aminya]

I'd rather only smoke test the older versions. The scripts and tests are for the developers of this repository who have a controlled environment with access to the latest tools.

So, trying to run these for such old Node versions doesn't really help.

For smoke testing, we can have a setup-node at the end of the pipeline install older node versions and just require zeromq to make sure it loads. The build and testing will be done with the latest Node.

[rotu]

I was not expecting CI to pass on these versions - I think we're on reasonably the same page.

Can you please fill in the blanks here?

• When you develop this package, it is okay to demand Node ___ and pnpm ___. (I think 22/9 is perfectly reasonable)
• When you consume this package, we expect you to be running Node ___ with package manager ___. (I think 18 / npm, pnpm, yarn berry)
• When you consume the types of this package, we expect TypeScript ___. (I think >=4.7.4, following the lead of typescript-eslint and DefinitelyTyped.

[aminya]

These are good questions. I'd say whatever is defined in CI, is the minimum requirement for the developers, and we aim to support as many as wide Nodejs versions as possible. However, it is not always practical.

So to find the range of Nodejs versions that can consume this project, we can add the above-mentioned smoke tests.

We already have compact tests for TypeScript:

zeromq.js/test/unit/typings-compatibility-test.ts

Line 27 in 828ed28

{version: "4.x", minTarget: "es3"},

[rotu]

I'd say whatever is defined in CI, is the minimum requirement for the developers, and we aim to support as many as wide Nodejs versions as possible. However, it is not always practical.
So to find the range of Nodejs versions that can consume this project, we can add the above-mentioned smoke tests.

I'm not asking what versions can consume this library per CI - as of recently, this library was completely broken in all of its CI. I'm asking what versions should we fix existing tests and set up smoke tests for?

• I'm asking what versions, if broken, would we regard as a problem?
• Even that typings compatibility test is maybe not so clear. By setting the version to 4.x I think that means only [email protected] is getting checked by CI, but your intention could have been that we support typescript as far back as 4.0. What version of TypeScript do you mean to target and why?

[aminya]

Closing in favour of #634