Implement Ice.Trace.Dispatch in C# #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Feb 5, 2025
| { | ||
| _instance.initializationData().logger.warning("dispatch exception:\n" + ex); | ||
| _instance.initializationData().logger.warning($"executor exception:\n{ex}"); |
There was a problem hiding this comment.
As of Ice 3.8, dispatch has the same meaning in Ice and IceRPC: the server-side processing of a request.
| { | ||
| callback.updated(changes); | ||
| } | ||
| catch (System.Exception ex) |
There was a problem hiding this comment.
I just removed this error handling. The user-supplied callback should not throw any exception, and if it does, it will get logged via Ice.Warn.Dispatch / Ice.Trace.Dispatch.
| _logger.warning("properties admin update callback raised unexpected exception:\n" + ex); | ||
| } | ||
| } | ||
| // The callback should not throw any exception. |
There was a problem hiding this comment.
We should remove these deprecated callbacks (for a separate PR).
pepone
approved these changes
Feb 6, 2025
externl
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Ice.Trace.Dispatch in C#.
Sample logging:
The message for dispatch exceptions is now different and shorter.
See #3498.
This PR also add a new property, Ice.Warn.Executor (default = 1), which prints warning when the user-installed executor throws exceptions.