Build deb packages #3495
Merged
Build deb packages #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Feb 4, 2025
| - name: Build Docker Image | ||
| run: docker build -f ${{ inputs.dockerfile_path }} -t ${{ inputs.docker_image }} . | ||
| run: docker build --pull -f ${{ inputs.dockerfile_path }} -t ice-deb-package-builder . | ||
| shell: bash |
There was a problem hiding this comment.
We should move the building of the Docker images to a separate workflow once we get stable builds. The same image would be reuse for different builds.
pepone
commented
Feb 4, 2025
| -e ICE_VERSION=${{ inputs.ice_version }} \ | ||
| -e DEB_BUILD_OPTIONS="${{ inputs.deb_build_options }}" \ | ||
| ice-debian-package-builder | ||
| --entrypoint /workspace/ice/packaging/dpkg/build-package.sh \ |
There was a problem hiding this comment.
We execute the build script from the mounted directory.
externl
reviewed
Feb 4, 2025
| name: "Build Debian Package" | ||
| description: "Builds a Debian source package using a Docker image" | ||
| name: "Build DEB Package" | ||
| description: "Builds a DEB package using a Docker image" | ||
| inputs: | ||
| ice_version: | ||
| description: "The ICE version to build" |
| shell: bash | ||
|
|
||
| - name: Run Package Build with Mounted Source | ||
| run: | | ||
| mkdir -p output | ||
| mkdir -p "$HOME/build" |
There was a problem hiding this comment.
I think's frowned upon to use $HOME and other dirs. It would be cleaner to clone ice into ${GITHUB_WORKSPACE}/ice like we do for the demos and create ${GITHUB_WORKSPACE}/build for the build to use
Co-authored-by: Joe George <[email protected]>
externl
reviewed
Feb 4, 2025
| -e ICE_VERSION=${{ inputs.ice_version }} \ | ||
| -e DEB_BUILD_OPTIONS="${{ inputs.deb_build_options }}" \ | ||
| ice-debian-package-builder | ||
| \ ice-deb-package-builder /workspace/ice/packaging/dpkg/build-package.sh |
There was a problem hiding this comment.
I don't t think this \ is necessary.
Suggested change
| \ ice-deb-package-builder /workspace/ice/packaging/dpkg/build-package.sh | |
| ice-deb-package-builder /workspace/ice/packaging/dpkg/build-package.sh |
externl
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixes for the DEB package builder action. See builds in https://github.com/zeroc-ice/ice/actions/workflows/build-deb-packages.yml