Fix more C++ modernize lints #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
requested review from
pepone,
externl and
InsertCreativityHere
bernardnormier
commented
Jan 14, 2025
| @@ -8,6 +8,7 @@ Checks: | |||
| -modernize-avoid-c-arrays, | |||
| -modernize-use-trailing-return-type, | |||
| -modernize-concat-nested-namespaces, | |||
| -modernize-use-default-member-init, | |||
There was a problem hiding this comment.
Suppressed for now as -fix doesn't deal well with macro conditionals and produces incorrect code.
| _subMaps.begin(); | ||
| p != _subMaps.end(); | ||
| ++p) | ||
| for (auto p = _subMaps.begin(); p != _subMaps.end(); ++p) |
There was a problem hiding this comment.
I don't know why -fix didn't convert this code in a loop.
There was a problem hiding this comment.
Actually, in this case, I prefer to leave it alone as the syntax is hard to decipher.
pepone
approved these changes
Jan 14, 2025
externl
reviewed
Jan 14, 2025
| @@ -31,15 +31,15 @@ namespace Ice::SSL | |||
| bool | |||
| DistinguishedName::match(const DistinguishedName& other) const | |||
| { | |||
| for (list<pair<string, string>>::const_iterator p = other._unescaped.begin(); p != other._unescaped.end(); ++p) | |||
| for (const auto& p : other._unescaped) | |||
There was a problem hiding this comment.
Would be nice to use a variable like name instead of p and q.
bernardnormier
requested review from
InsertCreativityHere,
pepone and
externl
bernardnormier
commented
Jan 14, 2025
externl
approved these changes
Jan 14, 2025
InsertCreativityHere
approved these changes
Jan 14, 2025
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
It also fixes the syntax for NOLINT.
It was mostly done using "-fix" ... but with additional fixes as "-fix" is not always correct/good.