Use getIceProperty as appropriate #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Nov 14, 2024
| @@ -200,7 +200,7 @@ Test::TestHelper::getTestEndpoint(const Ice::PropertiesPtr& properties, int num, | |||
| std::string protocol = prot; | |||
| if (protocol.empty()) | |||
| { | |||
| protocol = properties->getPropertyWithDefault("Ice.Default.Protocol", "default"); | |||
There was a problem hiding this comment.
This getPropertyWithDefault did not make sense.
transport default means "use the transport onfigured by Ice.Default.Protocol, and the default Ice.Default.Protocol is tcp. Setting Ice.Default.Protocol to 'default' should be disallowed since it's circular.
| @@ -200,7 +200,7 @@ Test::TestHelper::getTestEndpoint(const Ice::PropertiesPtr& properties, int num, | |||
| std::string protocol = prot; | |||
| if (protocol.empty()) | |||
| { | |||
| protocol = properties->getPropertyWithDefault("Ice.Default.Protocol", "default"); | |||
| protocol = properties->getIceProperty("Ice.Default.Protocol"); | |||
There was a problem hiding this comment.
This returns tcp when Ice.Default.Protocol is not set. The test scripts do set Ice.Default.Protocol.
pepone
approved these changes
Nov 15, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces various calls to getPropertyXxx by calls to getIcePropertyXxx.