Simplify the API for Reporting Parser Warnings #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Nov 4, 2024
cpp/src/Slice/Parser.h
Outdated
| @@ -226,11 +226,9 @@ namespace Slice | |||
| bool hasMetadata(std::string_view directive) const; | |||
| std::optional<std::string> getMetadataArgs(std::string_view directive) const; | |||
|
|
|||
| /// Emits a warning unless it should be filtered out by a [["suppress-warning"]]. | |||
| void warning(WarningCategory category, const std::string& file, int line, const std::string& message) const; | |||
| bool shouldSuppressWarning(WarningCategory category) const; | |||
There was a problem hiding this comment.
I find this function name odd. It probably should be something like isSuppressed.
There was a problem hiding this comment.
Fair enough, that name is simpler.
Changed.
InsertCreativityHere
added a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies how warnings are reported by the parser and compilers.
Previously we had 2 warnings: one on
Unit(think: a compilation run) and one onDefinitionContext(think: a file).This is already asymetric, but was also a pain since then we had to look up the context using a file name... which was doubly weird since we already had to pass in a file name to
warninganyways... and sometimes these could differ.This PR simplifies all this.
Now, all diagnostic reporting is handled by
Unit. There are 2 functions forerrorand 2 functions forwarning.One pair takes an explicit file name/line number, the other doesn't (and automatically uses the parser's current position).