Add C++ test for deprecated Slice metadata #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Nov 1, 2024
| @@ -71,21 +71,21 @@ namespace | |||
| } | |||
| } | |||
|
|
|||
| string getDeprecatedSymbol(const ContainedPtr& p1) | |||
| string getDeprecatedAttribute(const ContainedPtr& p1) | |||
There was a problem hiding this comment.
Renamed to match the C++ terminology.
| } | ||
| else | ||
| { | ||
| deprecatedSymbol = "[[deprecated]] "; | ||
| deprecatedAttribute = "[[deprecated]] "; |
There was a problem hiding this comment.
We actually never reach this line. See #3039.
| @@ -1338,21 +1338,24 @@ Slice::Gen::ForwardDeclVisitor::visitSequence(const SequencePtr& p) | |||
| string seqType = findMetadata(metadata, _useWstring); | |||
| writeDocSummary(H, p); | |||
|
|
|||
| string deprecatedAttribute = getDeprecatedAttribute(p); | |||
There was a problem hiding this comment.
sequences and dictionaries didn't get [[deprecated]] prior to this PR.
| << sp; | ||
| } | ||
|
|
||
| bool | ||
| Slice::Gen::ForwardDeclVisitor::visitStructStart(const StructPtr& p) | ||
| { | ||
| H << nl << "struct " << fixKwd(p->name()) << ';' << sp; | ||
| H << nl << "struct " << getDeprecatedAttribute(p) << fixKwd(p->name()) << ';' << sp; |
There was a problem hiding this comment.
Just for consistency. Doesn't matter since the C++ struct definition is always in the same file.
externl
approved these changes
Nov 1, 2024
InsertCreativityHere
approved these changes
Nov 4, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new C++ test (Slice/deprecated) and fixes a few bugs uncovered by this test.