Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Extra String Constructors that aren't Necessary Anymore #3036

Conversation

InsertCreativityHere
Copy link
Member

This is my follow up to #3026, which removes some extra string constructors that aren't necessary anymore.

Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

cpp/src/slice2java/JavaUtil.cpp Show resolved Hide resolved
cpp/src/slice2java/JavaUtil.cpp Outdated Show resolved Hide resolved
@InsertCreativityHere InsertCreativityHere merged commit be95bc0 into zeroc-ice:main Nov 4, 2024
18 of 19 checks passed
InsertCreativityHere added a commit to InsertCreativityHere/compiler-comparison that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants