More string API updates #3006
Merged
More string API updates #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Oct 29, 2024
| @@ -21,8 +19,8 @@ | |||
|
|
|||
| module Ice | |||
| { | |||
| /// A request context. <code>Context</code> is used to transmit metadata about a request from the server to the | |||
There was a problem hiding this comment.
The old description was bogus.
| /// its implicit final parameter. | ||
| /// A string-string dictionary, used to transmit additional information with an Ice request. This context is only | ||
| /// transmitted with requests, from clients to servers; the Ice protocol does not provide response contexts. | ||
| ["cpp:type:std::map<std::string, std::string, std::less<>>"] |
There was a problem hiding this comment.
The addition of std::less<> is the most disruptive part of this update.
pepone
approved these changes
Oct 30, 2024
| map<string, PluginFactory>* factories = 0; | ||
| vector<string>* loadOnInitialization = 0; | ||
| map<string, PluginFactory>* factories = nullptr; | ||
| vector<string>* loadOnInitialization = nullptr; |
There was a problem hiding this comment.
Unrelated to the PR, can we replace the raw-pointers, and custom deleter by an unique_ptr?
There was a problem hiding this comment.
That's not what this code is about. It's about static/lazy initialization and cleanup during static destruction.
There was a problem hiding this comment.
We can still do lazy initialization using unique_ptr, which would be destroyed during static destruction.
| _plugins.push_back(info); | ||
| info.name = std::move(name); | ||
| info.plugin = std::move(plugin); | ||
| _plugins.push_back(std::move(info)); |
There was a problem hiding this comment.
PluginInfo is a plain struct with no user-defined constructor. So no, it doesn't work.
externl
approved these changes
Oct 30, 2024
externl
approved these changes
Oct 30, 2024
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Communicator.h, Initialize.h, ImplicitContext.h and Plugin.h.