Fix JavaScript connection batch requests test #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Oct 28, 2024
bernardnormier
approved these changes
Oct 28, 2024
| test(bf.isCompleted()); | ||
| await b1.ice_flushBatchRequests(); | ||
| await b1.opBatch(); | ||
| await connection.flushBatchRequests(); | ||
| test(await p.waitForBatch(2)); | ||
| } | ||
|
|
||
| if ((await p.ice_getConnection()) !== null) { |
There was a problem hiding this comment.
When is this null?
AFAIK, there is no colloc in JS.
InsertCreativityHere
pushed a commit
to InsertCreativityHere/compiler-comparison
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the testing of batch requests with connection for JavaScript, the code was wrongfully testing the proxy batch request queue.